linux-kernel - Re: [PATCH][next] USB: serial: oti6858: Remove redundant assignment to variable divisor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZeXQzV3QOoclnNtT@hovoldconsulting.com>
Date: Mon, 4 Mar 2024 14:46:53 +0100
From: Johan Hovold <johan@...nel.org>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] USB: serial: oti6858: Remove redundant assignment
 to variable divisor

On Wed, Feb 07, 2024 at 10:18:33AM +0000, Colin Ian King wrote:
> The variable divisor is being assigned a value that is not being
> read afterward, it is being re-assigned later in both paths of an if
> statement.  The assignment is redundant and can be removed.
> 
> Cleans up clang scan warning:
> drivers/usb/serial/oti6858.c:412:2: warning: Value stored to 'divisor'
> is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Applied, thanks.

Johan