linux-kernel - Re: [RFC PATCH v5 1/1] fpga: add an owner and use it to take the low-level module's refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZeXRWDGvd8P7KhxJ@yilunxu-OptiPlex-7050>
Date: Mon, 4 Mar 2024 21:49:12 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: Marco Pagani <marpagan@...hat.com>
Cc: Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
	Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>,
	Jonathan Corbet <corbet@....net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Tull <atull@...nsource.altera.com>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-fpga@...r.kernel.org
Subject: Re: [RFC PATCH v5 1/1] fpga: add an owner and use it to take the
 low-level module's refcount

> Just to be sure that I understood correctly, you want to split the
> changes into two patches, like:
> 
> a) add module owner to the manager struct and take it in
> __fpga_mgr_get(); move put_device() from __fpga_mgr_get() to
> fpga_mgr_get() and of_fpga_mgr_get().
> 
> b) add the mutex and the unregistered flag for protection against races.
> 
> So that (b) can be reverted if try_module_get_safe() will be accepted?

Yes, that's what I mean.

> 
> > [...]
> 
> Thanks,
> Marco
> 
>