linux-kernel - Re: [PATCH v4 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36df8535-083f-4ce3-84c7-b8f652a9085b@notapiano>
Date: Mon, 4 Mar 2024 08:56:54 -0500
From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: Brian Norris <briannorris@...omium.org>,
	Julius Werner <jwerner@...omium.org>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nicolas Schier <nicolas@...sle.eu>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	kernel@...labora.com, chrome-platform@...ts.linux.dev,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Tzung-Bi Shih <tzungbi@...nel.org>
Subject: Re: [PATCH v4 0/4] Allow coreboot modules to autoload and enable
 cbmem in the arm64 defconfig

On Mon, Feb 12, 2024 at 09:50:04AM -0500, Nícolas F. R. A. Prado wrote:
> This series adds the missing pieces to the coreboot bus and the module
> alias generation to allow coreboot modules to be automatically loaded
> when matching devices are detected.
> 
> The configs for cbmem coreboot entries are then enabled in the arm64
> defconfig, as modules, to allow reading logs from coreboot on arm64
> Chromebooks, which is useful for debugging the boot process.
> 
> Changes in v4:
> - Added driver_data to device_id struct
> - Link to v3: https://lore.kernel.org/r/20240117-coreboot-mod-defconfig-v3-0-049565a27bba@collabora.com
> 
> Changes in v3:
> - Merged all "add to module device table" commits into a single commit
>   which also changes the coreboot_driver struct to contain an id table
>   and avoid unused variable warnings for the id tables.
> 
> Changes in v2:
> - Added commits for vpd, memconsole and framebuffer drivers to add them
>   to the module device table
> 
> ---
> Nícolas F. R. A. Prado (4):
>       firmware: coreboot: Generate modalias uevent for devices
>       firmware: coreboot: Generate aliases for coreboot modules
>       firmware: coreboot: Replace tag with id table in driver struct
>       arm64: defconfig: Enable support for cbmem entries in the coreboot table

Hi Arnd,

is it ok for Tzung-Bi to merge this last patch for the defconfig through the
chrome-platform-firmware tree?

Thanks,
Nícolas

> 
>  arch/arm64/configs/defconfig                   |  3 +++
>  drivers/firmware/google/cbmem.c                |  8 +++++++-
>  drivers/firmware/google/coreboot_table.c       | 20 +++++++++++++++++++-
>  drivers/firmware/google/coreboot_table.h       |  3 ++-
>  drivers/firmware/google/framebuffer-coreboot.c |  8 +++++++-
>  drivers/firmware/google/memconsole-coreboot.c  |  8 +++++++-
>  drivers/firmware/google/vpd.c                  |  8 +++++++-
>  include/linux/mod_devicetable.h                | 10 ++++++++++
>  scripts/mod/devicetable-offsets.c              |  3 +++
>  scripts/mod/file2alias.c                       | 10 ++++++++++
>  10 files changed, 75 insertions(+), 6 deletions(-)
> ---
> base-commit: 0f067394dd3b2af3263339cf7183bdb6ee0ac1f8
> change-id: 20240117-coreboot-mod-defconfig-826b01e242d9
> 
> Best regards,
> -- 
> Nícolas F. R. A. Prado <nfraprado@...labora.com>
>