linux-kernel - Re: [PATCH] i2c: exynos5: Init data before registering interrupt handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f4a2ada-0867-4ee0-bf27-4d69ab85b2e4@linaro.org>
Date: Mon, 4 Mar 2024 16:08:00 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Andi Shyti <andi.shyti@...nel.org>,
 Jesper Nilsson <jesper.nilsson@...s.com>
Cc: Alim Akhtar <alim.akhtar@...sung.com>, linux-i2c@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...s.com
Subject: Re: [PATCH] i2c: exynos5: Init data before registering interrupt
 handler

On 04/03/2024 16:04, Andi Shyti wrote:
>> -
>>  	i2c->variant = of_device_get_match_data(&pdev->dev);
>> +	if (!i2c->variant) {
>> +		dev_err(&pdev->dev, "can't match device variant\n");
>> +		return -ENODEV;
> 
> return dev_err_probe(), please.

How this condition even possibly happen? And how is this related to the
problem described here?

No, don't mix two different issues.

Best regards,
Krzysztof