linux-kernel - Re: [PATCH v8 01/12] firmware: qcom: add a dedicated TrustZone buffer allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f88d113-96c5-425f-9efa-34269581da09@quicinc.com>
Date: Mon, 4 Mar 2024 08:07:16 -0800
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Bartosz Golaszewski <brgl@...ev.pl>, Andy Gross <agross@...nel.org>,
        "Bjorn Andersson" <andersson@...nel.org>,
        Konrad Dybcio
	<konrad.dybcio@...aro.org>,
        Elliot Berman <quic_eberman@...cinc.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Guru Das Srinagesh
	<quic_gurus@...cinc.com>,
        Andrew Halaney <ahalaney@...hat.com>,
        "Maximilian
 Luz" <luzmaximilian@...il.com>,
        Alex Elder <elder@...aro.org>,
        "Srini
 Kandagatla" <srinivas.kandagatla@...aro.org>,
        Arnd Bergmann <arnd@...db.de>
CC: <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <kernel@...cinc.com>,
        "Bartosz
 Golaszewski" <bartosz.golaszewski@...aro.org>,
        Deepti Jaggi
	<quic_djaggi@...cinc.com>
Subject: Re: [PATCH v8 01/12] firmware: qcom: add a dedicated TrustZone buffer
 allocator

On 3/3/2024 7:01 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> We have several SCM calls that require passing buffers to the TrustZone
> on top of the SMC core which allocates memory for calls that require
> more than 4 arguments.
> 
> Currently every user does their own thing which leads to code
> duplication. Many users call dma_alloc_coherent() for every call which
> is terribly unperformant (speed- and size-wise).
> 
> Provide a set of library functions for creating and managing pools of
> memory which is suitable for sharing with the TrustZone, that is:
> page-aligned, contiguous and non-cachable as well as provides a way of
> mapping of kernel virtual addresses to physical space.
> 
> Make the allocator ready for extending with additional modes of operation
> which will allow us to support the SHM bridge safety mechanism once all
> users convert.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> Reviewed-by: Andrew Halaney <ahalaney@...hat.com>
> Tested-by: Andrew Halaney <ahalaney@...hat.com> # sc8280xp-lenovo-thinkpad-x13s
> Tested-by: Deepti Jaggi <quic_djaggi@...cinc.com> #sa8775p-ride
> Reviewed-by: Elliot Berman <quic_eberman@...cinc.com>
> ---
>  MAINTAINERS                              |   8 +
>  drivers/firmware/qcom/Kconfig            |  20 ++
>  drivers/firmware/qcom/Makefile           |   1 +
>  drivers/firmware/qcom/qcom_tzmem.c       | 392 +++++++++++++++++++++++
>  drivers/firmware/qcom/qcom_tzmem.h       |  13 +
>  include/linux/firmware/qcom/qcom_tzmem.h |  56 ++++
>  6 files changed, 490 insertions(+)
>  create mode 100644 drivers/firmware/qcom/qcom_tzmem.c
>  create mode 100644 drivers/firmware/qcom/qcom_tzmem.h
>  create mode 100644 include/linux/firmware/qcom/qcom_tzmem.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1794b8d7c76b..c1138c709365 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18327,6 +18327,14 @@ L:	linux-arm-msm@...r.kernel.org
>  S:	Maintained
>  F:	drivers/firmware/qcom/qcom_qseecom.c
>  
> +QUALCOMM TRUST ZONE MEMORY ALLOCATOR
> +M:	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> +L:	linux-arm-msm@...r.kernel.org
> +S:	Maintained
> +F:	drivers/firmware/qcom/qcom_tzmem.c
> +F:	drivers/firmware/qcom/qcom_tzmem.h
> +F:	include/linux/firmware/qcom/qcom_tzmem.h
> +
>  QUALCOMM QSEECOM UEFISECAPP DRIVER
>  M:	Maximilian Luz <luzmaximilian@...il.com>
>  L:	linux-arm-msm@...r.kernel.org

entries should be in alphabetic order so at a minimum QUALCOMM TRUST...
should be after QUALCOMM QSEECOM...

seems your addition belong just before QUALCOMM TSENS THERMAL DRIVER

/jeff