linux-kernel - Re: [PATCH v2 1/3] spi: axi-spi-engine: remove p from struct spi_engine_message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 4 Mar 2024 10:15:26 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: David Lechner <dlechner@...libre.com>, Mark Brown <broonie@...nel.org>
Cc: Michael Hennerich <michael.hennerich@...log.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Kees Cook <keescook@...omium.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>, linux-spi@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2 1/3] spi: axi-spi-engine: remove p from struct
 spi_engine_message_state



On 04/03/24 10:04, David Lechner wrote:
> The program pointer p in struct spi_engine_message_state in the AXI SPI
> Engine controller driver was assigned but never read so it can be
> removed.
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: David Lechner <dlechner@...libre.com>

Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks
--
Gustavo

> ---
>   drivers/spi/spi-axi-spi-engine.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
> index 6177c1a8d56e..d89f75170c9e 100644
> --- a/drivers/spi/spi-axi-spi-engine.c
> +++ b/drivers/spi/spi-axi-spi-engine.c
> @@ -82,8 +82,6 @@ struct spi_engine_program {
>    * struct spi_engine_message_state - SPI engine per-message state
>    */
>   struct spi_engine_message_state {
> -	/** @p: Instructions for executing this message. */
> -	struct spi_engine_program *p;
>   	/** @cmd_length: Number of elements in cmd_buf array. */
>   	unsigned cmd_length;
>   	/** @cmd_buf: Array of commands not yet written to CMD FIFO. */
> @@ -543,7 +541,6 @@ static int spi_engine_transfer_one_message(struct spi_controller *host,
>   
>   	/* reinitialize message state for this transfer */
>   	memset(st, 0, sizeof(*st));
> -	st->p = p;
>   	st->cmd_buf = p->instructions;
>   	st->cmd_length = p->length;
>   	msg->state = st;
>