linux-kernel - Re: [PATCH] ext2: remove SLAB_MEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240305141221.um4zuvnro7tg5fgq@quack3>
Date: Tue, 5 Mar 2024 15:12:21 +0100
From: Jan Kara <jack@...e.cz>
To: chengming.zhou@...ux.dev
Cc: jack@...e.com, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, vbabka@...e.cz, roman.gushchin@...ux.dev,
	Xiongwei.Song@...driver.com,
	Chengming Zhou <zhouchengming@...edance.com>
Subject: Re: [PATCH] ext2: remove SLAB_MEM_SPREAD flag usage

On Sat 24-02-24 13:48:16, chengming.zhou@...ux.dev wrote:
> From: Chengming Zhou <zhouchengming@...edance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>

Thanks. I've added the patch to my tree.

								Honza

> ---
>  fs/ext2/super.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 6d8587505cea..7162c61c0402 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -213,8 +213,7 @@ static int __init init_inodecache(void)
>  {
>  	ext2_inode_cachep = kmem_cache_create_usercopy("ext2_inode_cache",
>  				sizeof(struct ext2_inode_info), 0,
> -				(SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD|
> -					SLAB_ACCOUNT),
> +				SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT,
>  				offsetof(struct ext2_inode_info, i_data),
>  				sizeof_field(struct ext2_inode_info, i_data),
>  				init_once);
> -- 
> 2.40.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR