linux-kernel - Re: [PATCH 2/2] staging: vme_user: Add a newline after variable declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024030549-sanding-finisher-dc6a@gregkh>
Date: Tue, 5 Mar 2024 14:13:23 +0000
From: Greg KH <gregkh@...uxfoundation.org>
To: Jonathan Bergh <bergh.jonathan@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH 2/2] staging: vme_user: Add a newline after variable
 declarations

On Sun, Mar 03, 2024 at 11:05:47AM +0100, Jonathan Bergh wrote:
> This patch makes the following change:
>  * Adds a newline after the variable declarations as per checkpatch's
>    warning
> 
> Signed-off-by: Jonathan Bergh <bergh.jonathan@...il.com>
> ---
>  drivers/staging/vme_user/vme_tsi148.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> index 2a92497c5570..a1b8288b101a 100644
> --- a/drivers/staging/vme_user/vme_tsi148.h
> +++ b/drivers/staging/vme_user/vme_tsi148.h
> @@ -34,6 +34,7 @@ struct tsi148_driver {
>  	void __iomem *base;	/* Base Address of device registers */
>  	wait_queue_head_t dma_queue[2];
>  	wait_queue_head_t iack_queue;
> +
>  	void (*lm_callback[4])(void *);	/* Called in interrupt handler */
>  	void *lm_data[4];
>  	void *crcsr_kernel;

Please always look at the change to see if checkpatch is correct or not
(hint, for this one, it is not.)  Also see the archives for many people
who have done the same thing in the past :)

thanks,

greg k-h