linux-kernel - Re: [PATCH v6 1/3] dt-bindings: pci: layerscape-pci: Convert to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240305144636.GB3310214-robh@kernel.org>
Date: Tue, 5 Mar 2024 08:46:36 -0600
From: Rob Herring <robh@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: conor@...nel.org, bhelgaas@...gle.com, conor+dt@...nel.org,
	devicetree@...r.kernel.org, helgaas@...nel.org, imx@...ts.linux.dev,
	krzysztof.kozlowski+dt@...aro.org, kw@...ux.com,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	lpieralisi@...nel.org
Subject: Re: [PATCH v6 1/3] dt-bindings: pci: layerscape-pci: Convert to yaml
 format

On Mon, Mar 04, 2024 at 12:47:08PM -0500, Frank Li wrote:
> On Mon, Mar 04, 2024 at 11:32:04AM -0600, Rob Herring wrote:
> > On Fri, Mar 01, 2024 at 11:27:39AM -0500, Frank Li wrote:
> > > Split layerscape-pci.txt into two yaml files: fsl,layerscape-pcie-ep.yaml
> > > and fsl,layerscape-pcie.yaml.
> > > yaml files contain the same content as the original txt file.
> > > 
> > > Do below changes to pass dtb_binding check:
> > > - Remove dma-coherent and fsl,pcie-scfg because not every SOC need it.
> > 
> > You mean 'remove from required' right? Because they are still here.
> > 
> > > - Set unevaluatedProperties to true in fsl,layerscape-pcie.yaml.
> > 
> > Sorry, but that's not acceptable either. You need the $ref's in this 
> > patch.
> 
> 
> Rob:
> 
> If I squash this 3 patches, it will match most your comments. And will back
> to my previous v3's patches, 
> https://lore.kernel.org/imx/20240214194145.2669744-1-Frank.Li@nxp.com/

Plus our review comments I hope...

> 
> Bjorn Helgaas suggest split to patches:
> https://lore.kernel.org/imx/20240226210842.GA211190@bhelgaas/
> 
> First one will be equal to origial txt, then add change base on that.
> 
> I need a clear direction before I continue on this.

Bjorn's suggestion doesn't work. I think it was confused in that you 
said you were 'adding' things. You aren't adding things, just fixing 
things to make the validation pass.

If you want to split things, you could add reg and/or interrupt names to 
the common schema first. And then add Layerscape schemas. But don't add 
things you turn around and remove in the very next patch. I think 
Krzysztof told you the very same thing.

Rob