linux-kernel - Re: [PATCH] sched/fair: Remove stale FREQUENCY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 5 Mar 2024 15:18:20 +0000
From: Christian Loehle <christian.loehle@....com>
To: Vincent Guittot <vincent.guittot@...aro.org>
Cc: linux-kernel@...r.kernel.org, mingo@...hat.com, peterz@...radead.org,
 dietmar.eggemann@....com
Subject: Re: [PATCH] sched/fair: Remove stale FREQUENCY_UTIL comment

On 05/03/2024 15:05, Vincent Guittot wrote:
> On Tue, 5 Mar 2024 at 10:51, Christian Loehle <christian.loehle@....com> wrote:
>>
>> effective_cpu_util() flags were removed, so remove the comment part
>> mentioning it.
>>
>> commit 9c0b4bb7f6303 ("sched/cpufreq: Rework schedutil governor performance estimation")
>> reworked effective_cpu_util() removing enum cpu_util_type.
>>
>> Signed-off-by: Christian Loehle <christian.loehle@....com>
>> ---
>>  kernel/sched/fair.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 533547e3c90a..6b0c47d00fd3 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -7849,8 +7849,6 @@ eenv_pd_max_util(struct energy_env *eenv, struct cpumask *pd_cpus,
>>                  * Performance domain frequency: utilization clamping
>>                  * must be considered since it affects the selection
>>                  * of the performance domain frequency.
>> -                * NOTE: in case RT tasks are running, by default the
>> -                * FREQUENCY_UTIL's utilization can be max OPP.
> 
> Yes, it's no more accurate.
> Should we update the comment instead of deleting it as the effect is
> still there ?
>  "NOTE: in case RT tasks are running, by default the min utilization
> can be max OPP."

I'm fine with either and that was my first thought here, too, but it did seem like
the comment was mostly placed there to justify the 'unexpected' high utilization
when explicitly passing FREQUENCY_UTIL and the need to clamp it then.
So removing did feel slightly more natural to me anyway.

So alternatively:

From: Christian Loehle <christian.loehle@....com>
Date: Tue, 5 Mar 2024 09:34:41 +0000
Subject: [PATCH] sched/fair: Remove stale FREQUENCY_UTIL mention

effective_cpu_util() flags were removed, so remove mentioning of the
flag.

commit 9c0b4bb7f6303 ("sched/cpufreq: Rework schedutil governor performance estimation")
reworked effective_cpu_util() removing enum cpu_util_type. Modify the
comment accordingly.

Signed-off-by: Christian Loehle <christian.loehle@....com>
---
 kernel/sched/fair.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 533547e3c90a..f5151cbcd94e 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7849,8 +7849,8 @@ eenv_pd_max_util(struct energy_env *eenv, struct cpumask *pd_cpus,
 		 * Performance domain frequency: utilization clamping
 		 * must be considered since it affects the selection
 		 * of the performance domain frequency.
-		 * NOTE: in case RT tasks are running, by default the
-		 * FREQUENCY_UTIL's utilization can be max OPP.
+		 * NOTE: in case RT tasks are running, by default the min
+		 * utilization can be max OPP.
 		 */
 		eff_util = effective_cpu_util(cpu, util, &min, &max);
 
-- 
2.34.1