linux-kernel - Re: [PATCH v1 1/1] x86/rtc: Remove unused intel-mid.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14750023-e5fb-45f7-9c28-9510ce5a5994@intel.com>
Date: Tue, 5 Mar 2024 08:21:32 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Mateusz Jończyk <mat.jonczyk@...pl>,
 Mario Limonciello <mario.limonciello@....com>, linux-kernel@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v1 1/1] x86/rtc: Remove unused intel-mid.h

On 3/5/24 08:10, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
> this driver doesn't use it, so simply remove the unused header.

Indeed.  intel-mid.h provides a pretty small amount of stuff and it's
included in quite a few random-looking spots.  There's also gunk that's
only compiled in if CONFIG_X86_INTEL_MID=y so if anyone _did_ somehow
use any of those functions in generic code, they'd probably be creating
compile problems.

Any chance you'd like to look a _bit_ more widely and just clean up all
of the unnecessary intel-mid.h #includes that are scattered around?