linux-kernel - Re: [PATCH v1 2/3] watchdog: intel-mid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72cd08af-7334-49f7-9ac3-5a9ef93ed134@roeck-us.net>
Date: Tue, 5 Mar 2024 09:57:26 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
	Wim Van Sebroeck <wim@...ux-watchdog.org>
Subject: Re: [PATCH v1 2/3] watchdog: intel-mid_wdt: Don't use "proxy" headers

On Tue, Mar 05, 2024 at 06:52:19PM +0200, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/intel-mid_wdt.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index b41c45582aa4..06d5d207a065 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -9,11 +9,17 @@
>   *      Contact: David Cohen <david.a.cohen@...ux.intel.com>
>   */
>  
> +#include <linux/bitops.h>
> +#include <linux/device.h>
> +#include <linux/errno.h>
>  #include <linux/interrupt.h>
> +#include <linux/math.h>
>  #include <linux/module.h>
> -#include <linux/nmi.h>
> +#include <linux/panic.h>
>  #include <linux/platform_device.h>
> +#include <linux/types.h>
>  #include <linux/watchdog.h>
> +
>  #include <linux/platform_data/intel-mid_wdt.h>
>  
>  #include <asm/intel_scu_ipc.h>
> -- 
> 2.43.0.rc1.1.gbec44491f096
>