[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3beff31a-78a4-471f-a0cd-22379414a298@seco.com>
Date: Tue, 5 Mar 2024 13:07:07 -0500
From: Sean Anderson <sean.anderson@...o.com>
To: Rob Herring <robh@...nel.org>
Cc: Li Yang <leoyang.li@....com>, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org,
Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] soc: fsl: qbman: Remove RESERVEDMEM_OF_DECLARE usage
On 3/5/24 13:02, Rob Herring wrote:
>
> On Thu, 01 Feb 2024 13:29:30 -0600, Rob Herring wrote:
>> There is no reason to use RESERVEDMEM_OF_DECLARE() as the initialization
>> hook just saves off the base address and size. Use of
>> RESERVEDMEM_OF_DECLARE() is reserved for non-driver code and
>> initialization which must be done early. For qbman, retrieving the
>> address and size can be done in probe just as easily.
>>
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> ---
>> drivers/soc/fsl/qbman/bman_ccsr.c | 27 +++---------
>> drivers/soc/fsl/qbman/dpaa_sys.c | 12 +++--
>> drivers/soc/fsl/qbman/dpaa_sys.h | 4 +-
>> drivers/soc/fsl/qbman/qman_ccsr.c | 73 ++++++++++---------------------
>> 4 files changed, 38 insertions(+), 78 deletions(-)
>>
>
> No one is going to pick this up? I applied to the DT tree.
As discussed in [1], this driver is currently orphaned.
--Sean
[1] https://lore.kernel.org/all/20240219153016.ntltc76bphwrv6hn@skbuf/
[Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embeddedworld2024/Register/ew24517689>
Powered by blists - more mailing lists