linux-kernel - Re: [PATCH v5 2/7] scsi: libsas: Define NCQ Priority sysfs attributes for SATA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a80f1045-fb19-6871-46c2-11ae78dad8f0@huawei.com>
Date: Tue, 5 Mar 2024 10:44:42 +0800
From: Jason Yan <yanaijie@...wei.com>
To: Igor Pylypiv <ipylypiv@...gle.com>, Damien Le Moal <dlemoal@...nel.org>,
	Niklas Cassel <cassel@...nel.org>, John Garry <john.g.garry@...cle.com>,
	"James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen"
	<martin.petersen@...cle.com>, Jack Wang <jinpu.wang@...ud.ionos.com>, "Hannes
 Reinecke" <hare@...e.de>, Xiang Chen <chenxiang66@...ilicon.com>, "Artur
 Paszkiewicz" <artur.paszkiewicz@...el.com>, Bart Van Assche
	<bvanassche@....org>
CC: TJ Adams <tadamsjr@...gle.com>, <linux-ide@...r.kernel.org>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/7] scsi: libsas: Define NCQ Priority sysfs attributes
 for SATA devices

On 2024/3/5 8:50, Igor Pylypiv wrote:
> Libata sysfs attributes cannot be used for libsas managed SATA devices
> because the ata_port location is different for libsas.
> 
> Defined sysfs attributes (visible for SATA devices only):
> - /sys/block/sda/device/ncq_prio_enable
> - /sys/block/sda/device/ncq_prio_supported
> 
> The newly defined attributes will pass the correct ata_port to libata
> helper functions.
> 
> Reviewed-by: John Garry<john.g.garry@...cle.com>
> Reviewed-by: Damien Le Moal<dlemoal@...nel.org>
> Signed-off-by: Igor Pylypiv<ipylypiv@...gle.com>
> ---
>   drivers/scsi/libsas/sas_ata.c | 94 +++++++++++++++++++++++++++++++++++
>   include/scsi/sas_ata.h        |  6 +++
>   2 files changed, 100 insertions(+)

Reviewed-by: Jason Yan <yanaijie@...wei.com>