linux-kernel - Re: [PATCH] ssb: Fix potential NULL pointer dereference in ssb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <170966495037.424347.1344425289163744212.kvalo@kernel.org>
Date: Tue,  5 Mar 2024 18:55:52 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Rand Deeb <rand.sec96@...il.com>
Cc: Michael Buesch <m@...s.ch>, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org, deeb.rand@...fident.ru,
 lvc-project@...uxtesting.org, voskresenski.stanislav@...fident.ru,
 Rand Deeb <rand.sec96@...il.com>
Subject: Re: [PATCH] ssb: Fix potential NULL pointer dereference in
 ssb_device_uevent

Rand Deeb <rand.sec96@...il.com> wrote:

> The ssb_device_uevent function first attempts to convert the 'dev' pointer
> to 'struct ssb_device *'. However, it mistakenly dereferences 'dev' before
> performing the NULL check, potentially leading to a NULL pointer
> dereference if 'dev' is NULL.
> 
> To fix this issue, this patch moves the NULL check before dereferencing the
> 'dev' pointer, ensuring that the pointer is valid before attempting to use
> it.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Rand Deeb <rand.sec96@...il.com>
> Acked-by: Michael Büsch <m@...s.ch>

Failed to apply:

error: sha1 information is lacking or useless (drivers/ssb/main.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Applying: ssb: Fix potential NULL pointer dereference in ssb_device_uevent
Patch failed at 0001 ssb: Fix potential NULL pointer dereference in ssb_device_uevent

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240229093756.129324-1-rand.sec96@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches