linux-kernel - Re: [PATCH v1] riscv: dts: starfive: Remove PMIC interrupt info for Visionfive 2 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240305-macarena-fiber-f2460d371150@spud>
Date: Tue, 5 Mar 2024 19:41:39 +0000
From: Conor Dooley <conor@...nel.org>
To: Shengyu Qu <wiagn233@...look.com>
Cc: ganboing@...il.com, kernel@...il.dk, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, paul.walmsley@...ive.com,
	palmer@...belt.com, aou@...s.berkeley.edu, lee@...nel.org,
	andre.przywara@....com, jernej.skrabec@...il.com,
	linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v1] riscv: dts: starfive: Remove PMIC interrupt info for
 Visionfive 2 board

On Wed, Mar 06, 2024 at 01:11:50AM +0800, Shengyu Qu wrote:
> Since commit b2cb2ae22278f1918f7526b89760ee00b4a81393 ("mfd: axp20x:
> Generalise handling without interrupt"), interrupt info part for the
> AXP15060 PMIC is not needed anymore for Statfive Visionfive 2 board.
> And this would cause kernel to try to enable interrupt line 0, which is
> not expected. So delete this part from device tree.

interrupt-controller/#interrupt-cells are required properties, you can't
delete them. If you ran dtbs_check you'd see that it complains about
this patch.

If you just remove the interrupts property, what happens?

> Cc: stable@...r.kernel.org
> Fixes: b2cb2ae22278 ("mfd: axp20x: Generalise handling without interrupt")

This Fixes tag cannot be right, a dts patch cannot fix a driver. The dts
patch that incorrectly said this used interrupt 0 is what should be in the
Fixes tag.

Thanks,
Conor.

> Reported-by: Bo Gan <ganboing@...il.com>

Closes: https://lore.kernel.org/linux-riscv/c8b6e960-2459-130f-e4e4-7c9c2ebaa6d3@gmail.com/

> Signed-off-by: Shengyu Qu <wiagn233@...look.com>
> ---
>  arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> index b89e9791efa7..6bebabe3fa37 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> @@ -189,9 +189,6 @@ &i2c5 {
>  	axp15060: pmic@36 {
>  		compatible = "x-powers,axp15060";
>  		reg = <0x36>;
> -		interrupts = <0>;
> -		interrupt-controller;
> -		#interrupt-cells = <1>;
>  
>  		regulators {
>  			vcc_3v3: dcdc1 {
> -- 
> 2.39.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)