linux-kernel - RE: [PATCH 1/4] scsi: ufs: Re-use device management locking code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 5 Mar 2024 19:51:32 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "James E . J . Bottomley"
	<jejb@...ux.vnet.ibm.com>, "Martin K . Petersen" <martin.petersen@...cle.com>
CC: Bean Huo <beanhuo@...ron.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/4] scsi: ufs: Re-use device management locking code

 
> On 3/4/24 01:23, Avri Altman wrote:
> >   /**
> >    * ufshcd_exec_dev_cmd - API for sending device management requests
> >    * @hba: UFS hba
> > @@ -3291,11 +3305,6 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba
> *hba,
> >       struct ufshcd_lrb *lrbp;
> >       int err;
> >
> > -     /* Protects use of hba->reserved_slot. */
> > -     lockdep_assert_held(&hba->dev_cmd.lock);
> > -
> > -     down_read(&hba->clk_scaling_lock);
> > -
> >       lrbp = &hba->lrb[tag];
> >       lrbp->cmd = NULL;
> >       err = ufshcd_compose_dev_cmd(hba, lrbp, cmd_type, tag);
> 
> Please restore the lockdep_assert_held() call.
Done.

> 
> > -     /* Protects use of hba->reserved_slot. */
> > -     lockdep_assert_held(&hba->dev_cmd.lock);
> > -
> > -     down_read(&hba->clk_scaling_lock);
> > -
> >       lrbp = &hba->lrb[tag];
> >       lrbp->cmd = NULL;
> >       lrbp->task_tag = tag;
> 
> Same comment here - please restore the lockdep_assert_held() call.
Done.

Thanks,
Avri

> 
> Otherwise this patch looks good to me.
> 
> Thanks,
> 
> Bart.