linux-kernel - Re: [PATCH v1] slimbus: qcom-ngd-ctrl: Add timeout for wait operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8dbcd393-580b-4c29-9d6f-42988a5e7655@linaro.org>
Date: Tue, 5 Mar 2024 22:19:07 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Viken Dadhaniya <quic_vdadhani@...cinc.com>, andersson@...nel.org,
 srinivas.kandagatla@...aro.org, linux-arm-msm@...r.kernel.org,
 alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Cc: quic_msavaliy@...cinc.com, quic_vtanuku@...cinc.com,
 quic_anupkulk@...cinc.com, quic_cchiluve@...cinc.com
Subject: Re: [PATCH v1] slimbus: qcom-ngd-ctrl: Add timeout for wait operation



On 3/4/24 14:42, Viken Dadhaniya wrote:
> In current driver qcom_slim_ngd_up_worker() indefinitely
> waiting for ctrl->qmi_up completion object. This is
> resulting in workqueue lockup on Kthread.
> 
> Added wait_for_completion_interruptible_timeout to
> allow the thread to wait for specific timeout period and
> bail out instead waiting infinitely.
> 
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@...cinc.com>
> ---

Fixes: a899d324863a ("slimbus: qcom-ngd-ctrl: add Sub System Restart support")
Cc: stable@...r.kernel.org

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

>   drivers/slimbus/qcom-ngd-ctrl.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
> index efeba8275a66..c27076d8b7db 100644
> --- a/drivers/slimbus/qcom-ngd-ctrl.c
> +++ b/drivers/slimbus/qcom-ngd-ctrl.c
> @@ -83,6 +83,7 @@
>   
>   #define QCOM_SLIM_NGD_AUTOSUSPEND	MSEC_PER_SEC
>   #define SLIM_RX_MSGQ_TIMEOUT_VAL	0x10000
> +#define SLIM_QMI_TIMEOUT_MS		1000

This could be inlined instead

Konrad