linux-kernel - Re: [PATCH] pinctrl: pinmux: Suppress error message for -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYnFrB87T9Pq_kFDL_x399haA1n2hxPN0aSYO=KQSQQ6g@mail.gmail.com>
Date: Tue, 5 Mar 2024 23:30:02 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Andre Przywara <andre.przywara@....com>
Cc: linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: pinmux: Suppress error message for -EPROBE_DEFER

On Tue, Mar 5, 2024 at 3:39 PM Andre Przywara <andre.przywara@....com> wrote:

> EPROBE_DEFER error returns are not really critical, since they cancel
> the probe process, but the kernel will return later and retry.
> However, depending on the probe order, this might issue quite some
> verbatim and scary, though pointless messages:
>
> [    2.388731] 300b000.pinctrl: pin-224 (5000000.serial) status -517
> [    2.397321] 300b000.pinctrl: could not request pin 224 (PH0) from group PH0  on device 300b000.pinctrl
>
> Replace dev_err() with dev_err_probe(), which not only drops the
> priority of the message from error to debug, but also puts some text
> into debugfs' devices_deferred file, for later reference.
>
> Signed-off-by: Andre Przywara <andre.przywara@....com>

That does cut a lot of noise.

Patch applied!

Yours,
Linus Walleij