linux-kernel - Re: [PATCH v4 3/3] hwmon: Driver for Nuvoton NCT7363Y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cffada5e-0f7a-415f-9c4b-7c46fac5cd3a@hatter.bewilderbeest.net>
Date: Mon, 4 Mar 2024 16:28:35 -0800
From: Zev Weiss <zev@...ilderbeest.net>
To: baneric926@...il.com
Cc: jdelvare@...e.com, linux@...ck-us.net, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	corbet@....net, linux-hwmon@...r.kernel.org,
	devicetree@...r.kernel.org, kcfeng0@...oton.com, kwliu@...oton.com,
	openbmc@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, DELPHINE_CHIU@...ynn.com,
	naresh.solanki@...ements.com, billy_tsai@...eedtech.com
Subject: Re: [PATCH v4 3/3] hwmon: Driver for Nuvoton NCT7363Y

On Sat, Mar 02, 2024 at 12:19:07AM PST, Zev Weiss wrote:
>On Mon, Feb 26, 2024 at 04:56:06PM PST, baneric926@...il.com wrote:

<snip>

>
>>+
>>+	fanin_cnt = of_property_count_u8_elems(child, "tach-ch");
>>+	if (fanin_cnt < 1)
>
>fanin_cnt < 1 || fanin_cnt >= NCT7363_PWM_COUNT
>

Er, off by one -- just '>' rather than '>=' there I realize now.


Zev