linux-kernel - Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cys9pl55.fsf@mail.lhotse>
Date: Tue, 05 Mar 2024 11:39:18 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Jani Nikula <jani.nikula@...el.com>, linuxppc-dev@...ts.ozlabs.org
Cc: dri-devel@...ts.freedesktop.org, lkft-triage@...ts.linaro.org,
 linux-kernel@...r.kernel.org, Naresh
 Kamboju <naresh.kamboju@...aro.org>, Thomas Zimmermann
 <tzimmermann@...e.de>, Helge Deller <deller@....de>,
 linux-fbdev@...r.kernel.org
Subject: Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

Jani Nikula <jani.nikula@...el.com> writes:
> On Mon, 04 Mar 2024, Jani Nikula <jani.nikula@...el.com> wrote:
>> Removal of the backlight include from fb.h uncovered an implicit
>> dependency in powerpc asm/backlight.h. Add the explicit include.
>>
>> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
>> Closes: https://lore.kernel.org/r/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com
>> Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header")
>> Cc: Thomas Zimmermann <tzimmermann@...e.de>
>> Cc: Helge Deller <deller@....de>
>> Cc: linux-fbdev@...r.kernel.org
>> Signed-off-by: Jani Nikula <jani.nikula@...el.com>
>>
>> ---
>>
>> Not even compile tested!
>
> Naresh, please try this patch!
>
> Michael, if this is fine by you, ack to merge via the drm subsystem
> along with the regressing commit?

I prefer Thomas' patch, but I'm fine with either to go in via drm.

cheers