linux-kernel - Re: [PATCH] block: move capacity validation to blkpg_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d3dbc08-654c-46f6-a53d-43deeda5c14f@kernel.org>
Date: Tue, 5 Mar 2024 16:06:47 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Li Lingfeng <lilingfeng@...weicloud.com>, axboe@...nel.dk,
 min15.li@...sung.com
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, hch@....de,
 yangerkun@...wei.com, yukuai1@...weicloud.com, houtao1@...wei.com,
 yi.zhang@...wei.com
Subject: Re: [PATCH] block: move capacity validation to blkpg_do_ioctl()

On 3/5/24 12:21, Li Lingfeng wrote:
> From: Li Lingfeng <lilingfeng3@...wei.com>
> 
> Commit 6d4e80db4ebe ("block: add capacity validation in
> bdev_add_partition()") add check of partition's start and end sectors to
> prevent exceeding the size of the disk when adding partitions. However,
> there is still no check for resizing partitions now.
> Move the check to blkpg_do_ioctl() to cover resizing partitions.
> 
> Signed-off-by: Li Lingfeng <lilingfeng3@...wei.com>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

But I wonder if this needs a Fixes: 6d4e80db4ebe ("block: add capacity
validation in bdev_add_partition()") tag and Cc-stable...

-- 
Damien Le Moal
Western Digital Research