linux-kernel - Re: [PATCH v19 008/130] x86/tdx: Warning with 32bit build shift-count-overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240305081219.GC10568@ls.amr.corp.intel.com>
Date: Tue, 5 Mar 2024 00:12:19 -0800
From: Isaku Yamahata <isaku.yamahata@...ux.intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc: "Huang, Kai" <kai.huang@...el.com>, isaku.yamahata@...el.com,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	isaku.yamahata@...il.com, Paolo Bonzini <pbonzini@...hat.com>,
	erdemaktas@...gle.com, Sean Christopherson <seanjc@...gle.com>,
	Sagi Shahar <sagis@...gle.com>, chen.bo@...el.com,
	hang.yuan@...el.com, tina.zhang@...el.com,
	isaku.yamahata@...ux.intel.com
Subject: Re: [PATCH v19 008/130] x86/tdx: Warning with 32bit build
 shift-count-overflow

On Fri, Mar 01, 2024 at 01:36:43PM +0200,
"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com> wrote:

> On Thu, Feb 29, 2024 at 11:49:13AM +1300, Huang, Kai wrote:
> > 
> > 
> > On 26/02/2024 9:25 pm, isaku.yamahata@...el.com wrote:
> > > From: Isaku Yamahata <isaku.yamahata@...el.com>
> > > 
> > > This patch fixes the following warnings.
> > > 
> > >     In file included from arch/x86/kernel/asm-offsets.c:22:
> > >     arch/x86/include/asm/tdx.h:92:87: warning: shift count >= width of type [-Wshift-count-overflow]
> > >     arch/x86/include/asm/tdx.h:20:21: note: expanded from macro 'TDX_ERROR'
> > >     #define TDX_ERROR                       _BITUL(63)
> > > 
> > >                                             ^~~~~~~~~~
> > > 
> 
> I think you trim the warning message. I don't see the actual user of the
> define. Define itself will not generate the warning. You need to actually
> use it outside of preprocessor. I don't understand who would use it in
> 32-bit code. Maybe fixing it this way masking other issue.
>
> That said, I don't object the change itself. We just need to understand
> the context more.

v18 used it as stub function. v19 dropped it as the stub was not needed.
-- 
Isaku Yamahata <isaku.yamahata@...ux.intel.com>