[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdUYuucVQDor3na-iT+Jmsktr+vCVjQXGUA6vXd6-mXxmA@mail.gmail.com>
Date: Tue, 5 Mar 2024 09:14:01 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc: andy@...nel.org, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, andrew@...n.ch, gregory.clement@...tlin.com,
sebastian.hesselbarth@...il.com, lee@...nel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-leds@...r.kernel.org
Subject: Re: [PATCH v4 1/3] auxdisplay: Add 7-segment LED display driver
Hi Chris,
On Tue, Mar 5, 2024 at 4:59 AM Chris Packham
<chris.packham@...iedtelesis.co.nz> wrote:
> Add a driver for a 7-segment LED display. At the moment only one
> character is supported but it should be possible to expand this to
> support more characters and/or 14-segment displays in the future.
>
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v4:
> - Fix one more usage of 7 segment
> - Move ASCII art diagram to DT binding
> - Include map_to_7segment.h for map_to_seg7()
> - Use initialiser for values in seg_led_update
Thanks for the update!
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -211,6 +211,16 @@ config ARM_CHARLCD
> line and the Linux version on the second line, but that's
> still useful.
>
> +config SEG_LED_GPIO
> + tristate "Generic 7-segment LED display"
"depends on GPIOLIB || COMPILE_TEST"?
The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists