linux-kernel - Re: [PATCH] usb: dwc3: qcom: Remove ACPI support from glue driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZebXLkA9kXzx6qNi@hovoldconsulting.com>
Date: Tue, 5 Mar 2024 09:26:22 +0100
From: Johan Hovold <johan@...nel.org>
To: Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Wesley Cheng <quic_wcheng@...cinc.com>,
	Konrad Dybcio <konrad.dybcio@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
	linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, quic_ppratap@...cinc.com,
	quic_jackp@...cinc.com
Subject: Re: [PATCH] usb: dwc3: qcom: Remove ACPI support from glue driver

On Tue, Mar 05, 2024 at 01:47:05PM +0530, Krishna Kurapati PSSNV wrote:
> On 3/5/2024 12:39 PM, Johan Hovold wrote:
> > On Tue, Mar 05, 2024 at 09:51:43AM +0530, Krishna Kurapati wrote:

> > You should update the Kconfig entry for USB_DWC3_QCOM as well and drop
> > the ACPI dependency.
> 
> Missed it. Thanks for the catch. The following is the one right ?
> 
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 5fc27b20df63..31078f3d41b8 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -131,7 +131,7 @@ config USB_DWC3_QCOM
>          tristate "Qualcomm Platform"
>          depends on ARCH_QCOM || COMPILE_TEST
>          depends on EXTCON || !EXTCON
> -       depends on (OF || ACPI)
> +       depends on OF

Right.

> > Looks good to me otherwise.
> 
> Thanks for the review. Wanted to reply to your comments on multiport 
> series depending on how this patch goes in upstream.
> 
> Can I push out v2 or wait for a couple of days (as a standard practice 
> before putting a new version) ?

I think you can send a v2 straight away in this case.

Johan