linux-kernel - Re: [PATCH v2] i2c: exynos5: Init data before registering interrupt handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vk5s2p43v7lmmuwh3mzvgqetu4luwodmkejf4va6xyxwgdn5eq@ej2mjdii3rle>
Date: Tue, 5 Mar 2024 10:53:13 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Jesper Nilsson <jesper.nilsson@...s.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Naveen Krishna Ch <ch.naveen@...sung.com>, 
	linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...s.com
Subject: Re: [PATCH v2] i2c: exynos5: Init data before registering interrupt
 handler

Hi Jesper,

I have taken your patch in my testing branch, but...

> +	/* Clear pending interrupts from u-boot or misc causes */
> +	exynos5_i2c_clr_pend_irq(i2c);
> +
> +	i2c->irq = ret = platform_get_irq(pdev, 0);

.. I get this checkpatch note:

  CHECK: multiple assignments should be avoided
  #60: FILE: drivers/i2c/busses/i2c-exynos5.c:932:
  +       i2c->irq = ret = platform_get_irq(pdev, 0);

You are still in time to fix it, or you can fix it later or you
can leave it as for me it's not a big deal.

But, please, next time, make sure to run checkpatch before
sending a patch.

Thanks,
Andi