linux-kernel - Re: [PATCH 3/9] sched/balancing: Change 'enum cpu_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xhsmhfrx5dkao.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
Date: Tue, 05 Mar 2024 11:50:39 +0100
From: Valentin Schneider <vschneid@...hat.com>
To: Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Cc: Shrikanth Hegde <sshegde@...ux.ibm.com>, Peter Zijlstra
 <peterz@...radead.org>, Vincent Guittot <vincent.guittot@...aro.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>, Linus Torvalds
 <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 3/9] sched/balancing: Change 'enum cpu_idle_type' to
 have more natural definitions

On 04/03/24 10:48, Ingo Molnar wrote:
> And gets rid of the double negation in these usages:
>
>   -               if (env->idle != CPU_NOT_IDLE && env->src_rq->nr_running <= 1)
>   +               if (env->idle && env->src_rq->nr_running <= 1)
>

Yes please :-)

> Furthermore, this makes code much more obvious where there's
> differentiation between CPU_IDLE and CPU_NEWLY_IDLE.
>
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Vincent Guittot <vincent.guittot@...aro.org>
> Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Valentin Schneider <vschneid@...hat.com>

Reviewed-by: Valentin Schneider <vschneid@...hat.com>