linux-kernel - Re: [PATCH v4 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJRtX8R-j6BfJC6We0Xh1e0sYe6_CyUjbznf7e-kNmcF0=Bcjw@mail.gmail.com>
Date: Tue, 5 Mar 2024 09:46:32 +0800
From: Jingbao Qiu <qiujingbao.dlmu@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: u.kleine-koenig@...gutronix.de, robh+dt@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, 
	paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu, 
	linux-pwm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	dlan@...too.org, inochiama@...look.com
Subject: Re: [PATCH v4 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC

On Mon, Mar 4, 2024 at 11:02 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 04/03/2024 14:40, Jingbao Qiu wrote:
> > On Mon, Mar 4, 2024 at 6:15 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@...aro.org> wrote:
> >>
> >> On 04/03/2024 10:02, Jingbao Qiu wrote:
> >>> Implement the PWM driver for CV1800.
> >>>
> >>> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@...il.com>
> >>
> >> ...
> >>
> >>> +
> >>> +     ret = devm_add_action_or_reset(&pdev->dev, devm_clk_rate_exclusive_put,
> >>> +                                    priv->clk);
> >>> +     if (ret) {
> >>> +             clk_rate_exclusive_put(priv->clk);
> >>> +             return ret;
> >>
> >> Please test this path - you have double put.
> >>
> >
> > Thank you for your reply. You're right. If the
> > devm_add_action_or_reset()  function
> > fails to add an action, it will call the action.
> >
> > By the way, if I need to resend the patch, should I wait for the
> > maintainer to review it, or
> > should I immediately correct this error and resend it.
>
> I recommend one patchset per day.
>

Thank you for your suggestion.

Best regards,
Jingbao Qiu