[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <096ae376-18d3-4edb-7a56-077a4eb02968@huawei.com>
Date: Tue, 5 Mar 2024 21:16:12 +0800
From: Jason Yan <yanaijie@...wei.com>
To: John Garry <john.g.garry@...cle.com>, <jejb@...ux.ibm.com>,
<martin.petersen@...cle.com>, <chenxiang66@...ilicon.com>,
<jinpu.wang@...ud.ionos.com>, <artur.paszkiewicz@...el.com>,
<dlemoal@...nel.org>, <ipylypiv@...gle.com>
CC: <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] scsi: pm8001: Use LIBSAS_SHT_BASE
On 2024/3/5 20:24, John Garry wrote:
> Use standard template for scsi_host_template structure to reduce
> duplication.
>
> Signed-off-by: John Garry <john.g.garry@...cle.com>
> ---
> drivers/scsi/pm8001/pm8001_init.c | 20 +-------------------
> 1 file changed, 1 insertion(+), 19 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index e6b1108f6117..1e63cb6cd8e3 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -110,29 +110,11 @@ static void pm8001_map_queues(struct Scsi_Host *shost)
> * The main structure which LLDD must register for scsi core.
> */
> static const struct scsi_host_template pm8001_sht = {
> - .module = THIS_MODULE,
> - .name = DRV_NAME,
> - .proc_name = DRV_NAME,
> - .queuecommand = sas_queuecommand,
> - .dma_need_drain = ata_scsi_dma_need_drain,
> - .target_alloc = sas_target_alloc,
> - .slave_configure = sas_slave_configure,
> + LIBSAS_SHT_BASE
> .scan_finished = pm8001_scan_finished,
> .scan_start = pm8001_scan_start,
> - .change_queue_depth = sas_change_queue_depth,
> - .bios_param = sas_bios_param,
> .can_queue = 1,
> - .this_id = -1,
> .sg_tablesize = PM8001_MAX_DMA_SG,
> - .max_sectors = SCSI_DEFAULT_MAX_SECTORS,
> - .eh_device_reset_handler = sas_eh_device_reset_handler,
> - .eh_target_reset_handler = sas_eh_target_reset_handler,
> - .slave_alloc = sas_slave_alloc,
> - .target_destroy = sas_target_destroy,
> - .ioctl = sas_ioctl,
> -#ifdef CONFIG_COMPAT
> - .compat_ioctl = sas_ioctl,
> -#endif
> .shost_groups = pm8001_host_groups,
> .sdev_groups = pm8001_sdev_groups,
> .track_queue_depth = 1,
>
Sorry, I missed that this driver doesn't have ->eh_abort_handler. Please
fix it.
Thanks,
Jason
Powered by blists - more mailing lists