linux-kernel - Re: [PATCH 6/6] scsi: isci: Use LIBSAS_SHT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 5 Mar 2024 21:21:37 +0800
From: Jason Yan <yanaijie@...wei.com>
To: John Garry <john.g.garry@...cle.com>, <jejb@...ux.ibm.com>,
	<martin.petersen@...cle.com>, <chenxiang66@...ilicon.com>,
	<jinpu.wang@...ud.ionos.com>, <artur.paszkiewicz@...el.com>,
	<dlemoal@...nel.org>, <ipylypiv@...gle.com>
CC: <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] scsi: isci: Use LIBSAS_SHT_BASE

On 2024/3/5 20:24, John Garry wrote:
> Use standard template for scsi_host_template structure to reduce
> duplication.
> 
> Signed-off-by: John Garry <john.g.garry@...cle.com>
> ---
>   drivers/scsi/isci/init.c | 22 +---------------------
>   1 file changed, 1 insertion(+), 21 deletions(-)
> 
> diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
> index d0a23ce4afba..49e64232def1 100644
> --- a/drivers/scsi/isci/init.c
> +++ b/drivers/scsi/isci/init.c
> @@ -155,31 +155,11 @@ static const struct attribute_group *isci_sdev_groups[] = {
>   };
>   
>   static const struct scsi_host_template isci_sht = {
> -
> -	.module				= THIS_MODULE,
> -	.name				= DRV_NAME,
> -	.proc_name			= DRV_NAME,
> -	.queuecommand			= sas_queuecommand,
> -	.dma_need_drain			= ata_scsi_dma_need_drain,
> -	.target_alloc			= sas_target_alloc,
> -	.slave_configure		= sas_slave_configure,
> +	LIBSAS_SHT_BASE
>   	.scan_finished			= isci_host_scan_finished,
>   	.scan_start			= isci_host_start,
> -	.change_queue_depth		= sas_change_queue_depth,
> -	.bios_param			= sas_bios_param,
>   	.can_queue			= ISCI_CAN_QUEUE_VAL,
> -	.this_id			= -1,
>   	.sg_tablesize			= SG_ALL,
> -	.max_sectors			= SCSI_DEFAULT_MAX_SECTORS,

max_sectors is not defined in LIBSAS_SHT_BASE.

Thanks,
Jaosn

> -	.eh_abort_handler		= sas_eh_abort_handler,
> -	.eh_device_reset_handler        = sas_eh_device_reset_handler,
> -	.eh_target_reset_handler        = sas_eh_target_reset_handler,
> -	.slave_alloc			= sas_slave_alloc,
> -	.target_destroy			= sas_target_destroy,
> -	.ioctl				= sas_ioctl,
> -#ifdef CONFIG_COMPAT
> -	.compat_ioctl			= sas_ioctl,
> -#endif
>   	.shost_groups			= isci_host_groups,
>   	.sdev_groups			= isci_sdev_groups,
>   	.track_queue_depth		= 1,
>