linux-kernel - Re: [PATCH v2 2/2] xfs: Remove duplicate include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 6 Mar 2024 07:36:24 -0800
From: "Darrick J. Wong" <djwong@...nel.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: chandan.babu@...cle.com, linux-xfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH v2 2/2] xfs: Remove duplicate include

On Tue, Mar 05, 2024 at 10:40:09AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/xfs_trace.c: xfs_bmap.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8385
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

> ---
> Changes in v2:
>   -Remove the second #include.
> 
>  fs/xfs/xfs_trace.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_trace.c b/fs/xfs/xfs_trace.c
> index 1a963382e5e9..3f253884fe5b 100644
> --- a/fs/xfs/xfs_trace.c
> +++ b/fs/xfs/xfs_trace.c
> @@ -38,7 +38,6 @@
>  #include "xfs_iomap.h"
>  #include "xfs_buf_mem.h"
>  #include "xfs_btree_mem.h"
> -#include "xfs_bmap.h"
>  
>  /*
>   * We include this last to have the helpers above available for the trace
> -- 
> 2.20.1.7.g153144c
> 
>