linux-kernel - Re: [PATCH 4/5] ASoC: wm8962: Fix wm8962_set_fll to use source instead of fll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90fc91ae-0009-4cf1-8dd4-0f711e9c0c74@sirena.org.uk>
Date: Wed, 6 Mar 2024 16:46:16 +0000
From: Mark Brown <broonie@...nel.org>
To: Stuart Henderson <stuarth@...nsource.cirrus.com>
Cc: shengjiu.wang@...il.com, Xiubo.Lee@...il.com,
	patches@...nsource.cirrus.com, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH 4/5] ASoC: wm8962: Fix wm8962_set_fll to use source
 instead of fll_id

On Wed, Mar 06, 2024 at 04:14:38PM +0000, Stuart Henderson wrote:

> Previously wm8962_set_fll was using fll_id to configure the source.

Which was a problem because...?

> This change is problematic, but it looks like there's limited
> users of this driver, and luckily they all seem to be intending to
> use WM8962_FLL_MCLK as the source which happens to have the same
> value as WM8962_FLL.

If the change is problematic why make it at all?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)