linux-kernel - Re: [PATCH v4] arm64: dts: qcom: qcm6490-idp: enable PMIC Volume and Power buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02a2e93b-f0f1-4506-9e17-444cfd1a208f@quicinc.com>
Date: Wed, 6 Mar 2024 11:02:08 +0800
From: hui liu <quic_huliu@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] arm64: dts: qcom: qcm6490-idp: enable PMIC Volume and
 Power buttons



On 3/6/2024 5:20 AM, Konrad Dybcio wrote:
> 
> 
> On 3/4/24 08:09, Hui Liu via B4 Relay wrote:
>> From: Hui Liu <quic_huliu@...cinc.com>
>>
>> The Volume Down & Power buttons are controlled by the PMIC via
>> the PON hardware, and the Volume Up is connected to a PMIC gpio.
>>
>> Enable the necessary hardware and setup the GPIO state for the
>> Volume Up gpio key.
>>
>> Signed-off-by: Hui Liu <quic_huliu@...cinc.com>
>> ---
> 
> [...]
> 
> 
>> +&pmk8350_pon {
>> +    status = "okay";
>> +};
> 
> This device is already enabled
Hi Konrad,

The status is not set in pmk8350.dtsi, so I thought we should set it for 
"okay" manually. Do you think so?

Thanks,
Hui
> 
> Konrad