linux-kernel - Re: [PATCH] kbuild: unexport abs_srctree and abs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 6 Mar 2024 19:42:47 +0100
From: Nicolas Schier <nicolas@...sle.eu>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: unexport abs_srctree and abs_objtree

On Wed, Mar 06, 2024 at 07:42:22PM +0900 Masahiro Yamada wrote:
> Commit 25b146c5b8ce ("kbuild: allow Kbuild to start from any directory")
> exported abs_srctree and abs_objtree to avoid recomputation after the
> sub-make. However, this approach turned out to be fragile.
> 
> Commit 5fa94ceb793e ("kbuild: set correct abs_srctree and abs_objtree
> for package builds") moved them above "ifneq ($(sub_make_done),1)",
> eliminating the need for exporting them.
> 
> These are only needed in the top Makefile. If an absolute path is
> required in sub-directories, you can use $(abspath ) or $(realpath )
> as needed.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---

Thanks, I appreciate that abs_* is only used in top-level Makefile.

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)