linux-kernel - Re: [PATCH] riscv: compat_vdso: align VDSOAS build log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <048b4cff-9f3e-48aa-8c17-043261888ad5@ghiti.fr>
Date: Wed, 6 Mar 2024 21:00:43 +0100
From: Alexandre Ghiti <alex@...ti.fr>
To: Masahiro Yamada <masahiroy@...nel.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 linux-riscv@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: compat_vdso: align VDSOAS build log

Hi Masahiro,

On 17/11/2023 13:58, Masahiro Yamada wrote:
> Add one more space after "VDSOAS" for better alignment in the build log.
>
> [Before]
>
>    LDS     arch/riscv/kernel/compat_vdso/compat_vdso.lds
>    VDSOAS arch/riscv/kernel/compat_vdso/rt_sigreturn.o
>    VDSOAS arch/riscv/kernel/compat_vdso/getcpu.o
>    VDSOAS arch/riscv/kernel/compat_vdso/flush_icache.o
>    VDSOAS arch/riscv/kernel/compat_vdso/note.o
>    VDSOLD  arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
>    VDSOSYM include/generated/compat_vdso-offsets.h
>
> [After]
>
>    LDS     arch/riscv/kernel/compat_vdso/compat_vdso.lds
>    VDSOAS  arch/riscv/kernel/compat_vdso/rt_sigreturn.o
>    VDSOAS  arch/riscv/kernel/compat_vdso/getcpu.o
>    VDSOAS  arch/riscv/kernel/compat_vdso/flush_icache.o
>    VDSOAS  arch/riscv/kernel/compat_vdso/note.o
>    VDSOLD  arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
>    VDSOSYM include/generated/compat_vdso-offsets.h
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
>   arch/riscv/kernel/compat_vdso/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/compat_vdso/Makefile b/arch/riscv/kernel/compat_vdso/Makefile
> index 62fa393b2eb2..3df4cb788c1f 100644
> --- a/arch/riscv/kernel/compat_vdso/Makefile
> +++ b/arch/riscv/kernel/compat_vdso/Makefile
> @@ -74,5 +74,5 @@ quiet_cmd_compat_vdsold = VDSOLD  $@
>                      rm $@...p
>   
>   # actual build commands
> -quiet_cmd_compat_vdsoas = VDSOAS $@
> +quiet_cmd_compat_vdsoas = VDSOAS  $@
>         cmd_compat_vdsoas = $(COMPAT_CC) $(a_flags) $(COMPAT_CC_FLAGS) -c -o $@ $<


Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks,

Alex