linux-kernel - Re: [PATCH] riscv: compat_vdso: install compat_vdso.so.dbg to /lib/modules/*/vdso/

Open Source and information security mailing list archives

Message-ID: <ca097f2a-59ec-4945-9860-5e380e1665e4@ghiti.fr>
Date: Wed, 6 Mar 2024 21:12:50 +0100
From: Alexandre Ghiti <alex@...ti.fr>
To: Masahiro Yamada <masahiroy@...nel.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 linux-riscv@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: compat_vdso: install compat_vdso.so.dbg to
 /lib/modules/*/vdso/

Hi Masahiro,

On 24/02/2024 04:37, Masahiro Yamada wrote:
> Ping x 2 ?
>
>
>
>
>
> On Sun, Jan 21, 2024 at 6:48 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>> On Fri, Nov 17, 2023 at 9:58 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>>> 'make vdso_install' installs debug vdso files to /lib/modules/*/vdso/.
>>>
>>> Only for the compat vdso on riscv, the installation destination differs;
>>> compat_vdso.so.dbg is installed to /lib/module/*/compat_vdso/.
>>>
>>> To follow the standard install destination and simplify the vdso_install
>>> logic, change the install destination to standard /lib/modules/*/vdso/.
>>>
>>> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
>>> ---
>>
>> Ping?
>> (in case "yet more RISC-V updates" happens)
>>
>>
>>
>>
>>>   arch/riscv/Makefile | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
>>> index a74be78678eb..5cbe596345c1 100644
>>> --- a/arch/riscv/Makefile
>>> +++ b/arch/riscv/Makefile
>>> @@ -146,7 +146,7 @@ endif
>>>   endif
>>>
>>>   vdso-install-y                 += arch/riscv/kernel/vdso/vdso.so.dbg
>>> -vdso-install-$(CONFIG_COMPAT)  += arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg:../compat_vdso/compat_vdso.so
>>> +vdso-install-$(CONFIG_COMPAT)  += arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
>>>
>>>   ifneq ($(CONFIG_XIP_KERNEL),y)
>>>   ifeq ($(CONFIG_RISCV_M_MODE)$(CONFIG_ARCH_CANAAN),yy)
>>> --
>>> 2.40.1
>>>
>>
>> --
>> Best Regards
>> Masahiro Yamada
>
>
> --
> Best Regards
> Masahiro Yamada
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

Couldn't changing this library install path break some existing 
application? I mean it kind of breaks where the library is expected to 
be right?

Thanks,

Alex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives