linux-kernel - Re: [PATCH v19 005/130] x86/virt/tdx: Export global metadata read infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a8b2f97-47eb-481b-9373-2f39461713d7@intel.com>
Date: Thu, 7 Mar 2024 10:23:45 +1300
From: "Huang, Kai" <kai.huang@...el.com>
To: Yi Sun <yi.sun@...ux.intel.com>, <isaku.yamahata@...el.com>,
	<yi.sun@...el.com>
CC: <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<isaku.yamahata@...il.com>, Paolo Bonzini <pbonzini@...hat.com>,
	<erdemaktas@...gle.com>, Sean Christopherson <seanjc@...gle.com>, Sagi Shahar
	<sagis@...gle.com>, <chen.bo@...el.com>, <hang.yuan@...el.com>,
	<tina.zhang@...el.com>, "Kirill A . Shutemov"
	<kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH v19 005/130] x86/virt/tdx: Export global metadata read
 infrastructure


> 
> However, the function cannot be compiled if its definition remains in the
> vmx/tdx/tdx.c file while disabling the CONFIG_TDX_HOST.
> 
> It would be better to move the definition to a shared location,
> allowing the host and guest to share the same code.
> 

No not in this series.  Such change needs to be in your series.

Thanks,
-Kai