linux-kernel - Re: [PATCH] cpuidle: kirkwood: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <h2sjdrgs7hwmbucr3rxlpusnkpj5tgq2fx27gijtrglr5ffhs6@s63cp4isu4mx>
Date: Wed, 6 Mar 2024 22:33:06 +0100
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: "Rafael J. Wysocki" <rafael@...nel.org>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: Yangtao Li <frank.li@...o.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpuidle: kirkwood: Convert to platform remove callback
 returning void

Hello Rafael, hello Daniel,

On Mon, Dec 04, 2023 at 12:55:17PM +0100, Uwe Kleine-König wrote:
> On Wed, Jul 12, 2023 at 05:40:13PM +0800, Yangtao Li wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is (mostly) ignored
> > and this typically results in resource leaks. To improve here there is a
> > quest to make the remove callback return void. In the first step of this
> > quest all drivers are converted to .remove_new() which already returns
> > void.
> > 
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> > 
> > Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > Signed-off-by: Yangtao Li <frank.li@...o.com>
> 
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> Can you pick this up?

This patch isn't in next yet. Is this still on someone's radar for
application? Would be great if this patch made it into the mainline
during the upcomming merge window.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)