linux-kernel - Re: [PATCH v3] i2c: exynos5: Init data before registering interrupt handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aw7v5lu3ufutytrosjuzwnws7vg5uqlhs6bwinaibusl762ef4@5eeqvsxo3fp3>
Date: Wed, 6 Mar 2024 23:00:16 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Alim Akhtar <alim.akhtar@...sung.com>, 
	Jesper Nilsson <jesper.nilsson@...s.com>, Naveen Krishna Ch <ch.naveen@...sung.com>, 
	linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...s.com
Subject: Re: [PATCH v3] i2c: exynos5: Init data before registering interrupt
 handler

Hi Krzysztof,

On Wed, Mar 06, 2024 at 04:14:30PM +0100, Krzysztof Kozlowski wrote:
> On 06/03/2024 12:55, Andi Shyti wrote:
> > Hi
> > 
> > On Tue, 05 Mar 2024 11:50:00 +0100, Jesper Nilsson wrote:
> >> devm_request_irq() is called before we initialize the "variant"
> >> member variable from of_device_get_match_data(), so if an interrupt
> >> is triggered inbetween, we can end up following a NULL pointer
> >> in the interrupt handler.
> >>
> >> This problem was exposed when the I2C controller in question was
> >> (mis)configured to be used in both secure world and Linux.
> >>
> >> [...]
> > 
> > Applied to i2c/i2c-host-fixes on
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git
> 
> If for any reason this is going to fixes, which marks its importance as
> fix, then it should go to stable as well. Please always cc-stable for
> such cases.

yes, thank you! I should have checked that, as well.

Andi