linux-kernel - Re: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration sequences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70b01df1-d651-4f6b-a7fc-8e16c18c6e32@lunn.ch>
Date: Thu, 7 Mar 2024 00:19:29 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Raju.Lakkaraju@...rochip.com
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	linux-kernel@...r.kernel.org, Bryan.Whitehead@...rochip.com,
	richardcochran@...il.com, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net 3/3] net: lan743x: Address problems with wake option
 flags configuration sequences

> I'm not able to find  any more "ethtool" documentations other than ethtool man page.
> 
> I have gone through the ethtool application code.
> (git://git.kernel.org/pub/scm/network/ethtool/ethtool.git) and check the WOL options.
> 
> In ioctl method (Not netlink), do_sset( ) function, before set the parameters, first get the WOL configuration.
> (i.e. in ethtool.c file, Line no. 3294)
> 
> Then, assign/overwrite WOL wanted config to wolopts parameter.

Thanks for documenting all this. So it does seem like wol options
overwrite, rather than add incrementally. So i would say the correct
'fix' here is to document that in the man page, because at the moment
it is not clear what should happen.

Now i need to go back and look at what your original issue was...

	Andrew