linux-kernel - [PATCH] i2c: remove redundant condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240306041900.22885-1-harry021633@gmail.com>
Date: Wed,  6 Mar 2024 12:19:00 +0800
From: "Hsin-Yu.Chen" <harry021633@...il.com>
To: wsa+renesas@...g-engineering.com
Cc: linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Hsin-Yu.Chen" <harry021633@...il.com>
Subject: [PATCH] i2c: remove redundant condition

I2C_M_RD is defined as 1 and `flag & I2C_M_RD` is one or zero
no need for an additional condition to obtain the value

Signed-off-by: Hsin-Yu.Chen <harry021633@...il.com>
---
 include/linux/i2c.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 652ecb7abeda..363dde9ef94f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -931,7 +931,7 @@ static inline int i2c_adapter_id(struct i2c_adapter *adap)
 
 static inline u8 i2c_8bit_addr_from_msg(const struct i2c_msg *msg)
 {
-	return (msg->addr << 1) | (msg->flags & I2C_M_RD ? 1 : 0);
+	return (msg->addr << 1) | (msg->flags & I2C_M_RD);
 }
 
 u8 *i2c_get_dma_safe_msg_buf(struct i2c_msg *msg, unsigned int threshold);
-- 
2.38.1