linux-kernel - Re: [PATCH 1/3] nvme: core: constify struct class usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0550f07-5b1c-4478-9063-f411b223788f@nvidia.com>
Date: Wed, 6 Mar 2024 05:23:10 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: "Ricardo B. Marliere" <ricardo@...liere.net>, Keith Busch
	<kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>, Christoph Hellwig
	<hch@....de>, Sagi Grimberg <sagi@...mberg.me>, James Smart
	<james.smart@...adcom.com>, Chaitanya Kulkarni <chaitanyak@...dia.com>
CC: "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/3] nvme: core: constify struct class usage

On 3/5/24 05:15, Ricardo B. Marliere wrote:
> Since commit 43a7206b0963 ("driver core: class: make class_register() take
> a const *"), the driver core allows for struct class to be in read-only
> memory, so move the structures nvme_class, nvme_subsys_class and
> nvme_ns_chr_class to be declared at build time placing them into read-only
> memory, instead of having to be dynamically allocated at boot time.
>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>
> ---
>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck