linux-kernel - Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <KL1PR02MB6283F5203E50CD87F344331689212@KL1PR02MB6283.apcprd02.prod.outlook.com>
Date: Wed, 6 Mar 2024 07:41:37 +0000
From: "Bolan Wang(Bolan)" <bolan.wang@...ocom.com>
To: Lars Melin <larsm17@...il.com>, "johan@...nel.org" <johan@...nel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC: "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants

> Hi Bolan,
> so you already know that other versions of the card will have the pid
> 0x01a1 and the serial interfaces will be of class ff but you don't know what those interfaces will be used for?
> You shall only add driver support for what you know today and not for something that might or might not be implemented in the future.

> For the device with pid 0x0115 you have listed an adb interface and adb interfaces should not be in the option driver.

Hi Lars:

Ok, I will remove 0x01a1 from option serial driver. And the adb listed in pid 0x0115 will also be removed.
Actually adb interface info with pid 0x0115 is: Class_ff&SubClass_42&Prot_01, the option driver will not bind it?
I will resubmit a new patch, please help review and abandon this.

thanks
bolan