linux-kernel - Re: [PATCH v5 5/7] riscv: Kconfig.socs: Split ARCH_CANAAN and SOC_CANAAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_91E604E3B4D51DA37045625242A81B07F909@qq.com>
Date: Wed, 6 Mar 2024 16:14:33 +0800
From: Yangyu Chen <cyy@...self.name>
To: Conor Dooley <conor.dooley@...rochip.com>
Cc: Guo Ren <guoren@...nel.org>,
 linux-riscv@...ts.infradead.org,
 Conor Dooley <conor@...nel.org>,
 Damien Le Moal <dlemoal@...nel.org>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>,
 Albert Ou <aou@...s.berkeley.edu>,
 devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 5/7] riscv: Kconfig.socs: Split ARCH_CANAAN and
 SOC_CANAAN_K210



> On Mar 6, 2024, at 16:01, Conor Dooley <conor.dooley@...rochip.com> wrote:
> 
> On Wed, Mar 06, 2024 at 07:38:52AM +0800, Guo Ren wrote:
> 
>> On Wed, Mar 6, 2024 at 7:04 AM Yangyu Chen <cyy@...self.name> wrote:
>>> 
>>> Since we have Canaan Kendryte K230 with MMU now. The use of SOC_CANAAN
>>> is no longer only referred to K210. Split them and add _K210 suffix
>>> to the name for old SOC_CANAAN. And allows ARCH_CANAAN to be selected
>>> for other Canaan SoCs.
>>> 
>>> Signed-off-by: Yangyu Chen <cyy@...self.name>
>>> ---
>>> arch/riscv/Kconfig.socs                        | 8 +++++---
>>> arch/riscv/Makefile                            | 2 +-
>>> arch/riscv/configs/nommu_k210_defconfig        | 3 ++-
>>> arch/riscv/configs/nommu_k210_sdcard_defconfig | 3 ++-
>>> drivers/clk/Kconfig                            | 4 ++--
>>> drivers/pinctrl/Kconfig                        | 4 ++--
>>> drivers/reset/Kconfig                          | 4 ++--
>>> drivers/soc/Makefile                           | 2 +-
>>> drivers/soc/canaan/Kconfig                     | 4 ++--
>>> 9 files changed, 19 insertions(+), 15 deletions(-)
> 
>> This patch cross so many subsystems, I am not sure about it. If I were
>> you, I would keep SOC_CANAAN and just add SOC_CANAAN_K230.
> 
> Right. That is why I didn't try to rename the symbol, and just left it
> as SOC_CANAAN, but if the relevant people ack it, the chances of a
> significant conflict are low.
> 

Maybe I should split this patch into different subsystems for better
review. I think at least drivers/soc/Makefile should changed to use
ARCH_CANAAN. Because we need some SoC drivers for K230 in the future.
And arch/riscv/Makefile should use SOC_CANAAN_K210 instead of
ARCH_CANAAN.  Because we should avoid the M-Mode loader build for
other Canaan SoCs except for K210.