linux-kernel - Re: [PATCH v3 2/2] nvme-rdma: short-circuit reconnect retries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c46e0284-6a19-4240-b41f-8455d663b1e4@nvidia.com>
Date: Wed, 6 Mar 2024 08:17:47 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Daniel Wagner <dwagner@...e.de>, James Smart <james.smart@...adcom.com>
CC: Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>, Sagi
 Grimberg <sagi@...mberg.me>, Hannes Reinecke <hare@...e.de>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] nvme-rdma: short-circuit reconnect retries

On 3/6/24 00:11, Chaitanya Kulkarni wrote:
> On 3/5/24 00:00, Daniel Wagner wrote:
>> From: Hannes Reinecke <hare@...e.de>
>>
>> Returning an nvme status from nvme_rdma_setup_ctrl() indicates
>> that the association was established and we have received a status
>> from the controller; consequently we should honour the DNR bit.
>> If not any future reconnect attempts will just return the same error, so
>> we can short-circuit the reconnect attempts and fail the connection
>> directly.
>>
>> Signed-off-by: Hannes Reinecke <hare@...e.de>
>> Signed-off-by: Daniel Wagner <dwagner@...e.de>
>> ---
>>
> same here, do we need a same fix for FC as well ? just curious ...
>
> Looks good.
>
> Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>
>
> -ck
>

fc already handles DNR in nvme_fc_reconnect_or_delete().

-ck