linux-kernel - Re: [PATCH v3] USB:UAS:return ENODEV when submit urbs fail with device not attached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d5254cf-27de-b689-352b-45698e265f5e@zhaoxin.com>
Date: Thu, 7 Mar 2024 01:58:06 +0800
From: "WeitaoWang-oc@...oxin.com" <WeitaoWang-oc@...oxin.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: <oneukum@...e.com>, <stern@...land.harvard.edu>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-scsi@...r.kernel.org>, <usb-storage@...ts.one-eyed-alien.net>,
	<WeitaoWang@...oxin.com>, <stable@...r.kernel.org>
Subject: Re: [PATCH v3] USB:UAS:return ENODEV when submit urbs fail with
 device not attached

On 2024/3/5 21:25, Greg KH wrote:
> 
> 
> On Fri, Mar 01, 2024 at 03:33:49AM +0800, Weitao Wang wrote:
>> In the scenario of entering hibernation with udisk in the system, if the
>> udisk was gone or resume fail in the thaw phase of hibernation. Its state
>> will be set to NOTATTACHED. At this point, usb_hub_wq was already freezed
>> and can't not handle disconnect event. Next, in the poweroff phase of
>> hibernation, SYNCHRONIZE_CACHE SCSI command will be sent to this udisk
>> when poweroff this scsi device, which will cause uas_submit_urbs to be
>> called to submit URB for sense/data/cmd pipe. However, these URBs will
>> submit fail as device was set to NOTATTACHED state. Then, uas_submit_urbs
>> will return a value SCSI_MLQUEUE_DEVICE_BUSY to the caller. That will lead
>> the SCSI layer go into an ugly loop and system fail to go into hibernation.
>>
>> On the other hand, when we specially check for -ENODEV in function
>> uas_queuecommand_lck, returning DID_ERROR to SCSI layer will cause device
>> poweroff fail and system shutdown instead of entering hibernation.
>>
>> To fix this issue, let uas_submit_urbs to return original generic error
>> when submitting URB failed. At the same time, we need to translate -ENODEV
>> to DID_NOT_CONNECT for the SCSI layer.
>>
>> Suggested-by: Oliver Neukum <oneukum@...e.com>
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Weitao Wang <WeitaoWang-oc@...oxin.com>
>> ---
>> v2->v3
>>   - Modify the description of this patch.
>>   - An error is returned directly when submitting URB fails.
> 
> This change breaks the build, please be more careful'
> 
> drivers/usb/storage/uas.c: In function ‘uas_submit_urbs’:
> drivers/usb/storage/uas.c:559:21: error: unused variable ‘urb’ [-Werror=unused-variable]
>    559 |         struct urb *urb;
>       |                     ^~~
> 

I'm sorry for the carelessness. Now, I have removed this unused variable
and completed the compilation test. I'll resubmit this patch with a new version.

Thanks
weitao