linux-kernel - Re: [PATCH v2] fuse: remove unneeded lock which protecting update of congestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegtjB1RufZBRTJ0wh_xdtbOdGkyuxVV9kNV98WxbUiqQFw@mail.gmail.com>
Date: Wed, 6 Mar 2024 11:09:28 +0100
From: Miklos Szeredi <miklos@...redi.hu>
To: Kemeng Shi <shikemeng@...weicloud.com>
Cc: bernd.schubert@...tmail.fm, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fuse: remove unneeded lock which protecting update of congestion_threshold

On Sat, 7 Oct 2023 at 09:40, Kemeng Shi <shikemeng@...weicloud.com> wrote:
>
> Commit 670d21c6e17f6 ("fuse: remove reliance on bdi congestion") change how
> congestion_threshold is used and lock in
> fuse_conn_congestion_threshold_write is not needed anymore.
> 1. Access to supe_block is removed along with removing of bdi congestion.
> Then down_read(&fc->killsb) which protecting access to super_block is no
> needed.
> 2. Compare num_background and congestion_threshold without holding
> bg_lock. Then there is no need to hold bg_lock to update
> congestion_threshold.
>
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>

Applied, thanks.

Miklos