linux-kernel - Re: [PATCH v3] drm/bridge: anx7625: Update audio status while detecting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87frx3zmg5.fsf@intel.com>
Date: Wed, 06 Mar 2024 12:25:30 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Hsin-Te Yuan <yuanhsinte@...omium.org>, Andrzej Hajda
 <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>,
 Robert Foss <rfoss@...nel.org>, Laurent Pinchart
 <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Hsin-Te
 Yuan <yuanhsinte@...omium.org>
Subject: Re: [PATCH v3] drm/bridge: anx7625: Update audio status while
 detecting

On Wed, 06 Mar 2024, Hsin-Te Yuan <yuanhsinte@...omium.org> wrote:
> Previously, the audio status was not updated during detection, leading
> to a persistent audio despite hot plugging events. To resolve this
> issue, update the audio status during detection.
>
> Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@...omium.org>
> ---
> Changes in v3:
> - Add Fixes tag. 

You don't need to send another version just to update commit message
trailers. They can either be added while applying, or when you need to
update the patch anyway.

Or, if b4 is used to apply the patches, it can automagically pick up the
trailers from replies to the patch with the Fixes: trailer.

> - Link to v2: https://lore.kernel.org/r/20240306-anx7625-v2-1-7138e00b25bf@chromium.org
>
> Changes in v2:
> - Add a space after the colons in the subject line.
> - Link to v1: https://lore.kernel.org/r/20240305-anx7625-v1-1-83ed3ccfa64c@chromium.org
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 29d91493b101a..9f0d0c5b8ebf5 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2481,15 +2481,22 @@ static void anx7625_bridge_atomic_disable(struct drm_bridge *bridge,
>  	mutex_unlock(&ctx->aux_lock);
>  }
>  
> +static void
> +anx7625_audio_update_connector_status(struct anx7625_data *ctx,
> +				      enum drm_connector_status status);
> +
>  static enum drm_connector_status
>  anx7625_bridge_detect(struct drm_bridge *bridge)
>  {
>  	struct anx7625_data *ctx = bridge_to_anx7625(bridge);
>  	struct device *dev = ctx->dev;
> +	enum drm_connector_status status;
>  
>  	DRM_DEV_DEBUG_DRIVER(dev, "drm bridge detect\n");
>  
> -	return anx7625_sink_detect(ctx);
> +	status = anx7625_sink_detect(ctx);
> +	anx7625_audio_update_connector_status(ctx, status);
> +	return status;
>  }
>  
>  static struct edid *anx7625_bridge_get_edid(struct drm_bridge *bridge,

I guess this could be applied with less context (-C 2) but the baseline
is old. In drm-misc-next, all of drm/bridge has moved on to struct
drm_edid.

BR,
Jani.


>
> ---
> base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72
> change-id: 20240305-anx7625-fe16d3a9d37d
>
> Best regards,

-- 
Jani Nikula, Intel