linux-kernel - Re: [PATCH v1 2/2] platform/x86: intel_scu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31213f82-196d-8ab0-6c24-a09a2db43388@linux.intel.com>
Date: Wed, 6 Mar 2024 12:44:03 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
cc: Hans de Goede <hdegoede@...hat.com>, 
    Julian Winkler <julian.winkler1@....de>, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
    Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: Remove unused
 intel-mid.h

On Tue, 5 Mar 2024, Andy Shevchenko wrote:

> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,

Both applied to review-ilpo. I fixed that double "are" for you while 
applying.

-- 
 i.


> this driver doesn't use it, so simply remove the unused header.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/platform/x86/intel_scu_pcidrv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel_scu_pcidrv.c b/drivers/platform/x86/intel_scu_pcidrv.c
> index d904fad499aa..dbf0310448da 100644
> --- a/drivers/platform/x86/intel_scu_pcidrv.c
> +++ b/drivers/platform/x86/intel_scu_pcidrv.c
> @@ -11,7 +11,6 @@
>  #include <linux/init.h>
>  #include <linux/pci.h>
>  
> -#include <asm/intel-mid.h>
>  #include <asm/intel_scu_ipc.h>
>  
>  static int intel_scu_pci_probe(struct pci_dev *pdev,
>