linux-kernel - Re: [PATCH v7 7/7] scsi: isci: Add libsas SATA sysfs attributes group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZehLv6ADtU4cU3rr@ryzen>
Date: Wed, 6 Mar 2024 11:55:59 +0100
From: Niklas Cassel <cassel@...nel.org>
To: Igor Pylypiv <ipylypiv@...gle.com>
Cc: Damien Le Moal <dlemoal@...nel.org>,
	John Garry <john.g.garry@...cle.com>,
	Jason Yan <yanaijie@...wei.com>,
	"James E.J. Bottomley" <jejb@...ux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Jack Wang <jinpu.wang@...ud.ionos.com>,
	Hannes Reinecke <hare@...e.de>,
	Xiang Chen <chenxiang66@...ilicon.com>,
	Artur Paszkiewicz <artur.paszkiewicz@...el.com>,
	Bart Van Assche <bvanassche@....org>,
	TJ Adams <tadamsjr@...gle.com>, linux-ide@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 7/7] scsi: isci: Add libsas SATA sysfs attributes group

On Tue, Mar 05, 2024 at 05:22:26PM -0800, Igor Pylypiv wrote:
> The added sysfs attributes group enables the configuration of NCQ Priority
> feature for HBAs that rely on libsas to manage SATA devices.
> 
> Reviewed-by: John Garry <john.g.garry@...cle.com>
> Reviewed-by: Damien Le Moal <dlemoal@...nel.org>
> Reviewed-by: Jason Yan <yanaijie@...wei.com>
> Signed-off-by: Igor Pylypiv <ipylypiv@...gle.com>
> ---
>  drivers/scsi/isci/init.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
> index 6277162a028b..8658dcd61b87 100644
> --- a/drivers/scsi/isci/init.c
> +++ b/drivers/scsi/isci/init.c
> @@ -149,6 +149,11 @@ static struct attribute *isci_host_attrs[] = {
>  
>  ATTRIBUTE_GROUPS(isci_host);
>  
> +static const struct attribute_group *isci_sdev_groups[] = {
> +	&sas_ata_sdev_attr_group,
> +	NULL
> +};
> +
>  static const struct scsi_host_template isci_sht = {
>  
>  	.module				= THIS_MODULE,
> @@ -176,6 +181,7 @@ static const struct scsi_host_template isci_sht = {
>  	.compat_ioctl			= sas_ioctl,
>  #endif
>  	.shost_groups			= isci_host_groups,
> +	.sdev_groups			= isci_sdev_groups,
>  	.track_queue_depth		= 1,
>  };
>  
> -- 
> 2.44.0.278.ge034bb2e1d-goog
> 

Reviewed-by: Niklas Cassel <cassel@...nel.org>